Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2023

addImage

Note This is an automated PR

Submitted by @maverickrp

Closes #188


Adding image to network MAINNET

Address: 0xd33526068d116ce69f19a9ee46f0bd304f21a51f

Link to block explorer ↗︎

Description Image
Original original
Optimized optimized

@github-actions
Copy link
Contributor Author

github-actions bot commented May 8, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@alfetopito
Copy link
Collaborator

There's a bug with the folder case:

Existing images were stored with the checksummed address, while the GH action lower cases them.
Besides this, MacOS is case insensitive, which gave me a hard time fixing the image.

Also, the image was a PNG, which isn't supported.

Img was fixed.

Need now to fix the token address cases in the repo/scripts to be consistent

@alfetopito alfetopito merged commit 22601f0 into develop May 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
@alfetopito alfetopito deleted the addImage/1_0xd33526068d116ce69f19a9ee46f0bd304f21a51f branch May 8, 2023 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AddImage] RPL on MAINNET

3 participants