Skip to content

Conversation

@anxolin
Copy link
Contributor

@anxolin anxolin commented Jul 3, 2023

  1. Adds exponential backoff logic so it can self heal and continue
image
  1. Also renames the script name (to leave it a bit more clear what it is)

  2. Adds a new env to avoid to use the CACHE files.

  3. Adds an indication of how many tokens left

image

Test

USE_CACHE=false yarn cowFi:tokens

@anxolin anxolin changed the title Exponential backoff Exponential backoff + do not cache + rename Jul 3, 2023
@anxolin anxolin marked this pull request as ready for review July 3, 2023 18:52
@anxolin anxolin force-pushed the exponential-backoff branch from f38a0d4 to 8c82545 Compare July 3, 2023 19:23
Copy link
Contributor

@nenadV91 nenadV91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one comment, great changes 👍

@anxolin anxolin changed the base branch from hackaton/tokens-page to main November 8, 2023 12:42
@anxolin anxolin requested a review from a team November 8, 2023 12:44
@anxolin anxolin force-pushed the exponential-backoff branch from 8c82545 to 655cca4 Compare November 8, 2023 12:47
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@anxolin
@nenadV91
You can retrigger this bot by commenting recheck in this Pull Request

@anxolin
Copy link
Contributor Author

anxolin commented Nov 8, 2023

Merging. Please, let me know once you review. I want to try asap the chron execution (follow up #219)

@anxolin anxolin merged commit b4e6e84 into main Nov 8, 2023
@anxolin anxolin deleted the exponential-backoff branch November 8, 2023 13:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there's one script in this repo running with TS, would it be too much work to turn these new scripts into TS too?


const TOTAL_LIST_LENGTH = 50;

const TOKENS_TO_REMOVE = ["agave-token", "fraction", "minerva-wallet"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question... u would need to ask @nenadV91

@anxolin
Copy link
Contributor Author

anxolin commented Nov 8, 2023

Follow up #305

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants