-
Notifications
You must be signed in to change notification settings - Fork 29
Exponential backoff + do not cache + rename #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f38a0d4 to
8c82545
Compare
nenadV91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one comment, great changes 👍
8c82545 to
655cca4
Compare
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
Merging. Please, let me know once you review. I want to try asap the chron execution (follow up #219) |
alfetopito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that there's one script in this repo running with TS, would it be too much work to turn these new scripts into TS too?
|
|
||
| const TOTAL_LIST_LENGTH = 50; | ||
|
|
||
| const TOKENS_TO_REMOVE = ["agave-token", "fraction", "minerva-wallet"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question... u would need to ask @nenadV91
|
Follow up #305 |
Also renames the script name (to leave it a bit more clear what it is)
Adds a new env to avoid to use the CACHE files.
Adds an indication of how many tokens left
Test