Skip to content

Conversation

@alfetopito
Copy link
Collaborator

Summary

Re-ran the permit script on gnosis chain (from cowprotocol/cowswap#4152) and found a few more supported tokens

Basically, any token bridged from mainnet should be supported now.

Other networks did not yield any new token.

@alfetopito alfetopito self-assigned this Apr 3, 2024
@alfetopito alfetopito requested a review from a team April 3, 2024 17:32
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEautiful! turning all this tokens into permitable

Do you have the file to input in CoW Swap for testing some of them?

@anxolin
Copy link
Contributor

anxolin commented Apr 4, 2024

I guess I can test in here, as the logic would be the same one cowprotocol/cowswap#4152

@alfetopito
Copy link
Collaborator Author

I guess I can test in here, as the logic would be the same one cowprotocol/cowswap#4152

Yes.
There you can manually check them one by one.
To test this updated file, I'd need to point another PR to the file in this PR.
I can do that if you'd like, but I think it's not necessary.

@alfetopito
Copy link
Collaborator Author

Keep in mind this cannot be merged until cowswap changes are in prod.
As the current prod code is not capable of properly signing the permit for the users, even if we say they are permittable.

@alfetopito alfetopito marked this pull request as draft April 4, 2024 08:53
@anxolin
Copy link
Contributor

anxolin commented Apr 4, 2024

I can do that if you'd like, but I think it's not necessary.

no we don't need that. I'm satisfied with the tests in the other PR

@alfetopito alfetopito force-pushed the fix/gnosis-chain-permit-info branch from 90406bb to 89740b0 Compare April 11, 2024 14:57
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@cowprotocol/permit-utils@0.1.2

View full report↗︎

@alfetopito alfetopito marked this pull request as ready for review April 11, 2024 14:58
@alfetopito alfetopito merged commit d446da9 into main Apr 11, 2024
@alfetopito alfetopito deleted the fix/gnosis-chain-permit-info branch April 11, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants