Skip to content

Conversation

@alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Feb 14, 2023

Summary

Part of #35

Adding issue template forms:

  • Add token
  • Remove token
  • Add image

For more info, see GH's docs on templates and the form syntax

Testing

Not possible to test until this is merged to main

@alfetopito alfetopito self-assigned this Feb 14, 2023
@alfetopito alfetopito requested review from a team February 15, 2023 11:32
@alfetopito
Copy link
Collaborator Author

Please post merge review

@alfetopito alfetopito merged commit 0cb926c into main Feb 15, 2023
@alfetopito alfetopito deleted the 35/issue-template-forms branch February 15, 2023 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
@anxolin
Copy link
Contributor

anxolin commented Feb 16, 2023

Post-merge review :)

This is super cool!

Only concern, since we do some things programmatically, should we not ask for the derived information? Like symbols, decimals, name will be derived form the address. Or this is just because we will save some time with the implementation?

image

@anxolin
Copy link
Contributor

anxolin commented Feb 16, 2023

For the images, you will post-process to optimize, right?

If so, why limiting the input to an image in IPFS. Should we allow to input any URL, and maybe provide a hint on how to upload it if they only have it locally? (like a simple service where they can drag and drop the image and get the URL

image

@alfetopito
Copy link
Collaborator Author

since we do some things programmatically, should we not ask for the derived information? Like symbols, decimals, name will be derived form the address. Or this is just because we will save some time with the implementation?

For that kind of info, we'd have to either get the info from onchain directly (more trustworthy) use a 3rd party api service.
For the former, not sure how feasible that is to do from within a github action.
For the later, I feel like it's just an extra step to adding it manually and we would have to trust the API info in correct.

I think for now requiring manual input is fine. We can re-iterate but I prefer to start like this

If so, why limiting the input to an image in IPFS. Should we allow to input any URL, and maybe provide a hint on how to upload it if they only have it locally? (like a simple service where they can drag and drop the image and get the URL

Great idea, I haven't thought of that. Will update

@alfetopito
Copy link
Collaborator Author

@anxolin #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants