feat: arb1 uniswap/coingecko mapped lists #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
force-pushed
the
feat/arb1-uniswap-mapped-list
branch
from
76633ca to
ca0fac8
Compare
alfetopito
commented
May 24, 2024
shoom3301
reviewed
May 27, 2024
shoom3301
approved these changes
May 27, 2024
alfetopito
commented
May 27, 2024
Comment on lines
+214
to
+216
| // Checks whether there's at least 10 units of given token at destination address | ||
| // This also filters out addresses that are not deployed, since the response in this case is `0x` | ||
| const isValidTokenAddress = +res[1] > 10 |
Collaborator
Author
There was a problem hiding this comment.
This is how we check whether the token exists at destination
anxolin
reviewed
May 28, 2024
| ) | ||
| .then((results) => parseBridgedAddressesResults(results, fetchBridgedAddressesCalls, tokensToReplace, chainId)) | ||
|
|
||
| const tokens = await multicall.callStatic |
Contributor
There was a problem hiding this comment.
aha! nice you check not only code, but you checked for the total supply which one of the few mandatory in ERC20
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mainnettoGnosis chainto also mapmainnettoArbitrum oneTo test