Skip to content

Conversation

@Felix0x
Copy link
Contributor

@Felix0x Felix0x commented Feb 22, 2023

Updated OHM token address. Previous address has been deprecated a while ago (logo remains the same)

Updated OHM token address. Previous address has been deprecated a while ago (logo remains the same)
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Felix0x
Copy link
Contributor Author

Felix0x commented Feb 22, 2023

I have read the CLA Document and I hereby sign the CLA

@Felix0x
Copy link
Contributor Author

Felix0x commented Feb 22, 2023

recheck

github-actions bot added a commit that referenced this pull request Feb 22, 2023
@alfetopito
Copy link
Collaborator

Hi @Felix0x thanks a lot for this PR!

A few questions regarding the change:

  1. What happens to the old token?
  2. Should people still be able to buy it?
  3. Should people still be able to sell it?
  4. How will users know it's a new version of the token?
  5. Will the token image remains exactly the same for both versions?

@Felix0x
Copy link
Contributor Author

Felix0x commented Feb 22, 2023

  1. The old token is fully deprecated at this point. The migration from v1 to v2 was finished >1 year ago. Users still holding v1 can still migrate from the old token to the new token, but otherwise it's not used anymore.

2 & 3. There are still some very small pools available for the v1 token. So theoretically users can still trade those by manually adding in the address, but it shouldn't be the default option. The vast majority of holders and traders today know only of the current ("v2") token.

  1. Since the migration was finished >1 year ago, almost all users have migrated already. All liquidity pools, integrations, and token listings are with the new token contract. If someone is still holding a v1 token they will be prompted to migrate when connecting to the Olympus website.

  2. Yes the logo is the same. See for example https://etherscan.io/token/0x383518188c0c6d7730d91b2c03a03c837814a899 (old) and https://etherscan.io/token/0x64aa3364f17a4d01c6f1751fd97c2bd3d7e7f1d5 (new)

@alfetopito
Copy link
Collaborator

@Felix0x thanks for the response.
It makes sense, I'll perform the replacement.

Also, I updated the token image as it was broken for some reason

@alfetopito alfetopito merged commit 7306570 into cowprotocol:main Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants