Skip to content

Conversation

@alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Feb 22, 2023

Summary

  • Optimized all images currently in the repo
  • Fixed broken images
  • Added missing images for recently added tokens

Optimization

Optimized using image magic command:

for img in *.png; do convert "$img" -depth 7 -resize 256x -posterize 24 -strip output.png && mv output.png "$img"; done

Then passed them through https://imageoptim.com/ for further size reduction.

Notes

Update 2023-03-01

Reverted images that looked too bad and manually adjusted them

Some images - mainly gradients - look worse.

Examples:

image
image

@fairlighteth should we have a special case for those?

Some images are not loading in this PR

Probably something is up with Github's image comparison.
You can still view the image accessing it directly
image

@alfetopito alfetopito self-assigned this Feb 22, 2023
@alfetopito alfetopito requested review from a team and fairlighteth February 22, 2023 15:01
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Are we making a big image out of a small one? Shouldn't we leave it at the original size if its less than 256x256?

image

Yes, this is one doesn't look good. Maybe you will need to play more with the parameters...

image

@alfetopito alfetopito changed the base branch from main to develop March 1, 2023 11:31
@alfetopito alfetopito requested a review from anxolin March 1, 2023 11:34
@alfetopito alfetopito merged commit 3562c46 into develop Mar 1, 2023
@alfetopito alfetopito deleted the update-images branch March 1, 2023 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants