Skip to content

Conversation

@anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 8, 2022

Adds a simple script to download the images from the file, and adds them to the project.

It can be used just to make sure the images can be downloaded, but the main reason why this was done now, is just to add all the images to the project to then upload to IPFS automatically and update the imageUris to use IPFS.

Run it by executing:

yarn downloadImages

image

Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if this could also resize images to the desired quality.

Also inside the cowswap list we will still reference the old images. Will there be another script that creates a list with the locally hosted ones?

@anxolin
Copy link
Contributor Author

anxolin commented Dec 8, 2022

Would be great if this could also resize images to the desired quality.

Yes, but if we do this Is in other PR. I think we should go step by step:

  • download images
  • upload to ipfs
  • update the JSON with the new images
  • publish to s3
  • GH action for new releases
  • Optimize images

Also inside the cowswap list we will still reference the old images. Will there be another script that creates a list with the locally hosted ones?

Yes, it would be other, i actually started and is easy to finish. But Im putting these parts on hold after what we discussed
#11

@anxolin anxolin merged commit 1f0b1d3 into main Dec 8, 2022
@fleupold
Copy link
Contributor

fleupold commented Dec 9, 2022

Yes, but if we do this Is in other PR. I think we should go step by step:

💯 agree! I think this would be a great automation task for @ahhda to work on once the DevOps migration is finished. For now (ie the next 1-2 months) I think having the manual process is fine.

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants