Skip to content

Commit 167e50b

Browse files
committed
fix: Stop propagation of event
This avoids triggering events for elements below the component, for example in Banks there are chips integrated into ListItems
1 parent 50e0248 commit 167e50b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

react/IntentDialogOpener/IntentDialogOpener.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const IntentDialogOpener = props => {
2828

2929
const openModal = ev => {
3030
ev.preventDefault()
31+
ev.stopPropagation()
3132
setModalOpened(true)
3233
}
3334
const closeModal = () => setModalOpened(false)

react/deprecated/IntentModal/IntentModal.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ class IntentModal extends Component {
4646
// FIXME: this should be fixed by diferenciating dismissAction (for closing
4747
// modal) and onCancel (for intent cancellation), but it implies deprecating
4848
// dismissAction first, ensure legacy, prevent regressions, etc.
49-
dismiss = once(() => {
49+
dismiss = once(evt => {
5050
const { dismissAction } = this.props
51-
dismissAction && dismissAction()
51+
dismissAction && dismissAction(evt)
5252
})
5353

5454
render() {

0 commit comments

Comments
 (0)