Skip to content

Commit ae133f4

Browse files
committed
feat(Viewer): Use getMetadataQualificationType from cozy-client
This method is used in cozy-ui Viewer to display metadata qualification for a paper. It has been partly migrated to cozy-client because it will be used in cozy-keys-browser.
1 parent 450fb74 commit ae133f4

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

react/Viewer/Panel/Qualification.jsx

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,35 +4,23 @@ import PropTypes from 'prop-types'
44
import {
55
isExpiringSoon,
66
formatMetadataQualification,
7-
KNOWN_DATE_METADATA_NAMES,
8-
KNOWN_INFORMATION_METADATA_NAMES,
9-
KNOWN_OTHER_METADATA_NAMES
7+
getMetadataQualificationType
108
} from 'cozy-client/dist/models/paper'
119

1210
import List from '../../List'
1311
import { withViewerLocales } from '../hoc/withViewerLocales'
1412
import ExpirationAlert from '../components/ExpirationAlert'
15-
import QualificationListItemContact from './QualificationListItemContact'
1613
import ActionMenuWrapper from './ActionMenuWrapper'
14+
import QualificationListItemContact from './QualificationListItemContact'
1715
import QualificationListItemDate from './QualificationListItemDate'
1816
import QualificationListItemInformation from './QualificationListItemInformation'
1917
import QualificationListItemOther from './QualificationListItemOther'
2018

21-
const makeQualificationListItemComp = metadataName => {
22-
if (KNOWN_DATE_METADATA_NAMES.includes(metadataName)) {
23-
return QualificationListItemDate
24-
}
25-
26-
if (KNOWN_INFORMATION_METADATA_NAMES.includes(metadataName)) {
27-
return QualificationListItemInformation
28-
}
29-
30-
if (KNOWN_OTHER_METADATA_NAMES.includes(metadataName)) {
31-
if (metadataName === 'contact') {
32-
return QualificationListItemContact
33-
}
34-
return QualificationListItemOther
35-
}
19+
const ComponentFromMetadataQualificationType = {
20+
contact: QualificationListItemContact,
21+
date: QualificationListItemDate,
22+
information: QualificationListItemInformation,
23+
other: QualificationListItemOther
3624
}
3725

3826
const isExpirationAlertHidden = file => {
@@ -77,7 +65,9 @@ const Qualification = ({ file }) => {
7765
<List className={'u-pv-1'}>
7866
{formatedMetadataQualification.map((meta, idx) => {
7967
const { name } = meta
80-
const QualificationListItemComp = makeQualificationListItemComp(name)
68+
const metadataQualificationType = getMetadataQualificationType(name)
69+
const QualificationListItemComp =
70+
ComponentFromMetadataQualificationType[metadataQualificationType]
8171

8272
return (
8373
<QualificationListItemComp

0 commit comments

Comments
 (0)