fix: Revert compatibility fixes for Android 5+ support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 8e41347 we changed compression libraries in order to increase Android minimum compatibility from SDK 26 (Android 8) to SDK 22 (Android 5.1) With latest Flagship app changes we encountered build issues due to this change. This is mainly due to removal of geolocation libraries that shared common dependencies We should be able to fix those dependencies, but because latest ReactNative versions break support for Android 5 and 6 and because we will also rework this library for nitro-modules support, we chose not to investigate this for now and revert this commit instead. However we also loose support for Android 7 but this impact only a very small number of users (less than 10) This commit is a revert from 8e41347
In a7a9610 we downgraded commons-io in order to increase Android minimum compatibility from SDK 26 (Android 8) to SDK 22 (Android 5.1) With latest Flagship app changes we encountered build issues due to this change. This is mainly due to removal of geolocation libraries that shared common dependencies We should be able to fix those dependencies, but because latest ReactNative versions break support for Android 5 and 6 and because we will also rework this library for nitro-modules support, we chose not to investigate this for now and revert this commit instead. However we also loose support for Android 7 but this impact only a very small number of users (less than 10) This commit is a revert from a7a9610
Ldoppea
force-pushed
the
feat/revert_compatibility
branch
from
1aa6bc0 to
2101354
Compare
zatteo
approved these changes
Apr 8, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 8, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 23, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 24, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 24, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 24, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 24, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 28, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 28, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 28, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Apr 30, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 6, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 14, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 14, 2025
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 14, 2025
Due to the removal of geolocation libraries we encountered some dependencies bug in the react-native-gzip library This new version should fix those issues Related PR: cozy/react-native-gzip#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 14, 2025
Due to the removal of geolocation libraries we encountered some dependencies bug in the react-native-gzip library This new version should fix those issues Related PR: cozy/react-native-gzip#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 20, 2025
Due to the removal of geolocation libraries we encountered some dependencies bug in the react-native-gzip library This new version should fix those issues Related PR: cozy/react-native-gzip#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 26, 2025
Due to the removal of geolocation libraries we encountered some dependencies bug in the react-native-gzip library This new version should fix those issues Related PR: cozy/react-native-gzip#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
May 26, 2025
Due to the removal of geolocation libraries we encountered some dependencies bug in the react-native-gzip library This new version should fix those issues Related PR: cozy/react-native-gzip#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a7a9610 and 8e41347 we changed compression libraries in order to increase Android minimum compatibility from SDK 26 (Android 8) to SDK 22 (Android 5.1)
With latest Flagship app changes we encountered build issues due to this change. This is mainly due to removal of geolocation libraries that shared common dependencies
We should be able to fix those dependencies, but because latest ReactNative versions break support for Android 5 and 6 and because we will also rework this library for nitro-modules support, we chose not to investigate this for now and revert this commit instead. However we also loose support for Android 7 but this impact only a very small number of users (less than 10)