fix: migrate SHA* digests to EVP_Q_digest on OpenSSL 3.x#119
Merged
timlegge merged 2 commits intocpan-authors:mainfrom Mar 19, 2026
Merged
Conversation
Member
Collaborator
|
@toddr-bot rebase with suggestions above |
SHA1(), SHA224(), SHA256(), SHA384(), and SHA512() are deprecated in OpenSSL 3.0+. The MD5 and RIPEMD160 cases in get_message_digest() were already migrated to EVP_Q_digest — apply the same treatment to all SHA variants for consistency and to eliminate deprecation warnings on OpenSSL 3.x builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toddr-bot
force-pushed
the
koan.toddr.bot/fix-deprecated-sha-digests
branch
from
d09711e to
f57cbb0
Compare
Contributor
Author
Rebase: fix: migrate SHA* digests to EVP_Q_digest on OpenSSL 3.xBranch Diff: 1 file changed, 24 insertions(+), 6 deletions(-) Review feedback was analyzed and applied. Actions
CICI passed. Automated by Kōan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate SHA1/SHA224/SHA256/SHA384/SHA512 in
get_message_digest()to useEVP_Q_digest()on OpenSSL 3.x.Why
These low-level SHA functions are deprecated since OpenSSL 3.0. The MD5 and RIPEMD160 cases were already migrated to
EVP_Q_digest()— the SHA family was overlooked.How
Applied the same
#if OPENSSL_VERSION_NUMBER >= 0x30000000L/EVP_Q_digest()pattern already used for MD5 and RIPEMD160 to all five SHA variants. Pre-3.x codepaths are unchanged.Testing
🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 20 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline