Merged
Conversation
Now that Crypt::OpenSSL::RSA has been removed, promote CryptX from a recommended dependency to a required one in PREREQ_PM. This ensures users get the fast XS crypto backend (Crypt::PK::RSA, Crypt::PK::ECC) by default. Crypt::Perl remains required for X.509 certificate generation (tls-alpn-01) and as a runtime fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promote CryptX from a recommended dependency to a required one in PREREQ_PM.
Why
With Crypt::OpenSSL::RSA removed, the only crypto backend in PREREQ_PM was Crypt::Perl (pure Perl). Users would get the slow pure-Perl crypto by default, with the fast XS backend (CryptX) merely recommended. Since the runtime code in AccountKey.pm already prefers CryptX, making it a hard dependency ensures users actually get it installed.
How
CryptX => 0to PREREQ_PM in Makefile.PLTesting
Full test suite passes (158 tests, 10 test files). Verified edited files compile cleanly.
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 7 insertions(+), 21 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline