Skip to content

Fixups for 4432 and 4433 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwakely merged 1 commit into from
Oct 27, 2025
Merged

Fixups for 4432 and 4433 #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/issue4432.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ template<ranges::input_range R>
<tt>T</tt> is a structural type (<sref ref="[temp.param]"/>),
<tt>is_constructible_v&lt;T, ranges::range_reference_t&lt;R&gt;&gt;</tt> is <tt>true</tt>, and
<del><tt>is_copy_constructible_v&lt;T&gt;</tt> is <tt>true</tt></del>
<ins><tt>T</tt> statisfies <tt>copy_constructible</tt></ins>.</p>
<ins><tt>T</tt> satisfies <tt>copy_constructible</tt></ins>.</p>
<p>-10- Let <tt>V</tt> be the pack of values of type info of the same size as <tt>r</tt>,
where the <i>i<sup>th</sup></i> element is
<tt>reflect_constant(<del><i>e<sub>i</sub></i></del><ins>static_cast&lt;T&gt;(*<i>it<sub>i</sub></i>)</ins>)</tt>,
where <i><del>e<sub>i</sub></del><ins>it<sub>i</sub></ins></i> is <ins>an iterator to</ins> the ith element of <tt>r</tt>.
where <i><del>e<sub>i</sub></del><ins>it<sub>i</sub></ins></i> is <ins>an iterator to</ins> the <i>i<sup>th</sup></i> element of <tt>r</tt>.
</p>
<p>[&hellip;]</p>
</blockquote>
Expand Down
7 changes: 5 additions & 2 deletions xml/issue4433.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
Language linkage is a property of functions, variables, and function types (<sref ref="[basic.link]"/>),
not of names.
</p>
<note>
The wording below contains a drive-by fix for a misapplication of <paper num="P2996R13"/>
</note>
</discussion>

<resolution>
Expand All @@ -37,7 +40,7 @@ consteval bool has_linkage(info r);
</pre>
<blockquote>
<p>-25- <i>Returns</i>: `true` if `r` represents a variable, function, type, template, or namespace
whose name has internal linkage, module linkage, <del>C language linkage, </del>or any linkage,
whose name has internal linkage, module linkage, <del>C language</del><ins>external</ins> linkage, or any linkage,
Copy link
Author

@timsong-cpp timsong-cpp Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like "external linkage" was accidentally omitted when P2996 was applied. I think it's easier to fix it as a drive-by here than as another editorial pull request.

respectively (<sref ref="[basic.link]"/>). Otherwise, `false`.</p>
</blockquote>

Expand All @@ -46,7 +49,7 @@ respectively (<sref ref="[basic.link]"/>). Otherwise, `false`.</p>
</pre>
<blockquote>
<p><ins>-??- <i>Returns</i>: `true` if `r` represents a variable, function, or function type with C language
linkage, module linkage. Otherwise, `false`.</ins></p>
linkage. Otherwise, `false`.</ins></p>
</blockquote>

</li>
Expand Down