New issue for US 239-367, US 240-370 #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dani-Hub
reviewed
Nov 5, 2025
Dani-Hub
reviewed
Nov 5, 2025
| <discussion> | ||
| <b>Addresses <a href="https://github.com/cplusplus/nbballot/issues/942">US 239-367</a></b> | ||
| <p>As specified, there is an implicit precondition that `sch_` is not moved from on all the | ||
| member functions. If that is intended, the precondition should be made explicit.</p> |
Member
There was a problem hiding this comment.
Do you mean "is not moved from for all the member functions"?
Author
There was a problem hiding this comment.
This is copied verbatim for NB comment.
tomaszkam
force-pushed
the
tk/task-issues
branch
from
580f227 to
b81a504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.