Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

The intent is that nested-mapping_ and extents_ belong to layout_transpose::mapping but not layout_transpose. This can also be inferred from their usages.

Towards #7214.

…t_transpose::mapping`

The intent is that _`nested-mapping_`_ and _`extents_`_ belong to
`layout_transpose::mapping` but not `layout_transpose`. This can also be
inferred from their usages.
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 5, 2025

@tkoeppe tkoeppe requested a review from jwakely November 5, 2025 09:34
@mhoemmen
Copy link
Contributor

mhoemmen commented Nov 5, 2025

@tkoeppe Thanks for the heads-up! That was definitely an error in the paper. The data members belong in layout_transpose::mapping, not in layout_transpose.

Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 5, 2025

@mhoemmen: Thanks for checking! That seems clearly editorial then, since the intent is clear and it was just a mistake.

@tkoeppe tkoeppe merged commit f4c6085 into cplusplus:main Nov 5, 2025
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the layout_transpose-mapping-members branch November 5, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants