[parallel.simd.reference] Fix swap value_type params to be lvalues #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the class definition of `simd::reference` the `value_type` parameters for `swap()` are rvalue references. This does not make sense; `swap()` must accept lvalue-references to `value_type` to be able to exchange the referred values. The detailed description of `swap()` in §16 already correctly uses lvalue-references for the `value_type` parameters. Also, http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0214r9.pdf uses lvalue-reference `value_type` parameters already in the `swap()` declaration in the definition of the `simd::reference` class.
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the class definition of
simd::referencethevalue_typeparameters forswap()are rvalue references. This does not make sense;swap()mustaccept lvalue-references to
value_typeto be able to exchange the referredvalues.
The detailed description of
swap()in §16 already correctly useslvalue-references for the
value_typeparameters.Also, http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0214r9.pdf uses
lvalue-reference
value_typeparameters already in theswap()declarationin the definition of the
simd::referenceclass.