Skip to content

Conversation

@blaz-kranjc
Copy link
Contributor

Conan is already used to fetch all the other dependencies. Fetching all dependencies in a similar manner (conan) reduces the complexity of using the project.

Conan is already used to fetch all the other dependencies. Change
introduces better consistency in dependency management.
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@69ccbc8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   12.84%           
=======================================
  Files           ?        3           
  Lines           ?      218           
  Branches        ?      125           
=======================================
  Hits            ?       28           
  Misses          ?      188           
  Partials        ?        2           
Flag Coverage Δ
Linux 6.17% <0.00%> (?)
Windows 12.04% <0.00%> (?)
macOS 5.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ccbc8...369f515. Read the comment docs.

@lefticus
Copy link
Member

@blaz-kranjc I agree in theory with this, because you're right that it makes little sense to get dependencies from two different places.

However, I'm also considering removing conan entirely from this project just to make it even easier to use.

I don't have a clear path forward here.

@0x8000-0000
Copy link

I was just about to ask about using Conan fully. FetchContent seems like a tool from before Conan/VCPKG and while it might be adequate for header-only libraries using a fully-featured package manager seems more like a 'best practice' than fetching stuff.

@lefticus
Copy link
Member

FetchContent seems like a tool from before Conan/VCPKG and while it might be adequate for header-only libraries using a fully-featured package manager seems more like a 'best practice' than fetching stuff.

Interestingly, the idea of making projects "FetchContent-able" is really more modern, almost as a response to conan and vcpkg

@lefticus lefticus merged commit 54a0af9 into cpp-best-practices:main Apr 14, 2022
@blaz-kranjc blaz-kranjc deleted the feature-ftxui-with-conan branch April 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants