Skip to content

Main menu prototype, upgrade logging #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2022
Merged

Main menu prototype, upgrade logging #34

merged 9 commits into from
Oct 24, 2022

Conversation

@karnkaul
Copy link
Member

@karnkaul karnkaul commented Oct 24, 2022 •
edited
Loading

Upgrade logger to:

  • Keep an "elastic" buffer of logs, referenced by the editor's log window
  • Also log to the VS debugger console
  • Also log to a file (facade.log) asynchronously
  • Populate / reset the file logger and clear the buffer using an RAII Instance

Also:

  • Add AsyncQueue<T>: "sleepy", efficient, offers blocking and non blocking APIs
  • Fix CI script to also run on pushes to branches
  • Expand and upgrade editor types
    • Support child windows
    • Add RAII StyleVar

Risks:

  • logger::Instance is created outside try block in main
    • solve for above

Close #9

@karnkaul
Editor, logging, main menu (prototype)
1c5a2f8 
- Expand and document editor wrappers.
- Upgrade logging internals, formalize `logger::Entry`.
- Display prototype main menu.
@karnkaul
Add log buffer and thread-safe read-only access
df9529b 
- Reflect log buffer in editor window (prototype).
@karnkaul
Attempt CI fix
9463ace 
Not triggering on pushes.
@karnkaul
Add threaded file logging
5a8a55a 
Risk: `std::jthread`, `std::stop_token` may not compile on Pi g++ yet.
@karnkaul
Wrap logger instance in try block too
b7c0898
@karnkaul karnkaul marked this pull request as ready for review October 24, 2022 02:49
@karnkaul
Move editor::Log to its own sources
276b2a2
@karnkaul
Move Renderer back to scene/
305b32a 
- This maintains a strict DAG of directories, which can be turned into libraries later: util <= vk <= glfw <= dear_imgui <= scene <= engine, editor
This DAG is currently loosely reflected in the order of sources in CMakeLists.txt.
@karnkaul karnkaul merged commit 5556025 into main Oct 24, 2022
@karnkaul karnkaul deleted the karnage/main-menu branch October 24, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor logging

1 participant

@karnkaul