Skip to content

Conversation

@nicola-lunghi
Copy link
Contributor

@nicola-lunghi nicola-lunghi commented Aug 14, 2025

CI: gets targets from docker buildx file
I cannot test this on my fork as the ci requires a secret from this repo

@shenxianpeng
Copy link
Collaborator

Thanks for the PR. I tried to fix the CI failure

Error when evaluating 'strategy' for job 'build'. .github/workflows/CI.yml (Line: 43, Col: 17): Error from function 'fromJson': empty input, .github/workflows/CI.yml (Line: 43, Col: 17): Unexpected value ''

But it does not correct. The error is still present.

@shenxianpeng shenxianpeng requested a review from Copilot August 14, 2025 11:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the CI workflow by dynamically extracting build targets from the docker-bake.hcl file instead of maintaining a hardcoded list in the GitHub Actions workflow. This approach ensures the CI automatically stays in sync with the Docker build configuration.

Key changes:

  • Added a new job to dynamically extract targets from the Docker bake file
  • Replaced hardcoded target matrix with dynamically generated targets from the bake file
  • Introduced dependency between jobs to pass extracted targets to the build job

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@shenxianpeng shenxianpeng added the enhancement New feature or request label Aug 14, 2025
@shenxianpeng shenxianpeng merged commit 0cadff8 into cpp-linter:master Aug 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants