Skip to content

Rename clang-tools binaries for Windows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2022
Merged

Rename clang-tools binaries for Windows #13

merged 6 commits into from
Aug 5, 2022

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Aug 5, 2022 •
edited
Loading

fixed #11

@shenxianpeng shenxianpeng added the bug Something isn't working label Aug 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #13 (bbc64f4) into main (0fdee8a) will decrease coverage by 2.62%.
The diff coverage is 20.00%.

❗ Current head bbc64f4 differs from pull request most recent head 9c1285d. Consider uploading reports for the commit 9c1285d to get more accurate results

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   76.51%   73.88%   -2.63%     
==========================================
  Files           6        7       +1     
  Lines         149      157       +8     
==========================================
+ Hits          114      116       +2     
- Misses         35       41       +6
Impacted Files Coverage Δ
clang_tools/install.py 52.77% <11.11%> (-4.80%) ⬇️
clang_tools/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shenxianpeng shenxianpeng merged commit 4687c09 into main Aug 5, 2022
@shenxianpeng shenxianpeng deleted the rename-binary branch August 5, 2022 11:01
shenxianpeng added a commit that referenced this pull request Aug 5, 2022
@shenxianpeng
Rename clang-tools binaries for Windows (#13)
9469813 
* Rename clang-tools binaries for Windows

* Update test

* Update function variables

* Add .gitpod.yml

* Update install

* Fix if condition
2bndy5
2bndy5 reviewed Aug 5, 2022
View reviewed changes
@2bndy5 2bndy5 mentioned this pull request Aug 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2bndy5 2bndy5 2bndy5 left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

binary executables should use '.exe' suffix on Windows

4 participants

@shenxianpeng @codecov-commenter @2bndy5