fix some reggression from #30 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels good to be done adding features and just fixing bugs. With every bug I find and fix, I feel that we are that much closer to a solid solution. |
shenxianpeng
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple scenarios:
versionnumber for which the .clang-format file was designed.ignorepaths usedstr.lstrip("./")which would lead to stripping the left-most.OR/. I have replacedlstrip("./")withstr.replace("./", "", 1), so only the exact left-most sequence of./is stripped../in a path that was prefixed with a!. Previously the relative path syntax was only striped from paths that didn't have the!prefix.