Skip to content

update thread-comments default value to false #46 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2022
Merged

update thread-comments default value to false #46 #47

merged 3 commits into from
Apr 5, 2022

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Apr 5, 2022 •
edited
Loading

See user disable thread-comments example https://github.com/fabiankachlock/zwoo/commit/733906da6da57a8eb540cce91480074855013c55

@shenxianpeng shenxianpeng requested a review from 2bndy5 April 5, 2022 06:16
2bndy5 added 2 commits April 5, 2022 01:05
@2bndy5
remove use of TOKEN when fetching thread comments
c5ff070 
This should resolve #46. It will not affect the fix for private repos since thread comments are now auto-disabled for private repos.
@2bndy5
fix imports for last commit
b2ade46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shenxianpeng
shenxianpeng commented Apr 5, 2022
View reviewed changes
Copy link
Collaborator Author

@shenxianpeng shenxianpeng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to merge it.

@shenxianpeng shenxianpeng merged commit c33e41d into master Apr 5, 2022
@shenxianpeng shenxianpeng deleted the update-thread-comments branch April 5, 2022 08:30
@shenxianpeng shenxianpeng added bug Something isn't working documentation Improvements or additions to documentation labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenxianpeng @2bndy5