-
Notifications
You must be signed in to change notification settings - Fork 0
fix: hero rendering #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Better color choice for anti-aliasing. * Better size and positioning for mobile and desktop. * Update mkdocs.yml config to silence warnings about unused documents (`blog/**`) * Update `repo_name` in mkdocs.yml to display GitHub org name instead of the generic default ("Github") * Disable markdownlint warnings as needed.
✅ Deploy Preview for cpp-linter-github-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
args: [--style=Google] # Other coding style: LLVM, GNU, Chromium, Microsoft, Mozilla, WebKit. | ||
- id: clang-tidy | ||
args: [--checks='boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*'] | ||
args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml format seems incorrect if users just copy and use it. Maybe id
and args
need to be aligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to YAML specs
list-name: [item]
# is equivalent to
list-name:
- item
I hadn't noticed the misaligned indent. That should be uniformed.
About the title, right now this PR changes it to How about
|
The hover buttons color can be uniformly yellow. I don't really care which title you want. Typically a title should be brief. I just changed the title because the |
Ok let's merge and I'll see if any other changes are needed to the button background color and title |
resolves #3
blog/**
)repo_name
in mkdocs.yml to display GitHub org name instead of the generic default ("Github")