Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 5, 2020

fixes #105

@CerenB and @marcobarilari

Can you check out this PR and makes sure that "it works for you"?

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #107 into dev will increase coverage by 0.94%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #107      +/-   ##
==========================================
+ Coverage   78.95%   79.90%   +0.94%     
==========================================
  Files          28       28              
  Lines         898      602     -296     
==========================================
- Hits          709      481     -228     
+ Misses        189      121      -68     
Flag Coverage Δ
#unittests 79.90% <85.36%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/checkCFG.m 98.83% <ø> (+0.42%) ⬆️
src/convertSourceToRaw.m 0.00% <ø> (ø)
src/createDatasetDescription.m 0.00% <ø> (ø)
src/createFilename.m 95.89% <ø> (+0.52%) ⬆️
src/createJson.m 51.21% <ø> (-1.02%) ⬇️
src/saveEventsFile.m 94.16% <ø> (+0.90%) ⬆️
src/subfun/askForGroupAndOrSession.m 100.00% <ø> (ø)
src/subfun/askUserCli.m 0.00% <ø> (ø)
src/subfun/askUserGui.m 0.00% <ø> (ø)
src/subfun/checkCppBidsDependencies.m 50.00% <ø> (+4.54%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2986e21...52f3039. Read the comment docs.

@Remi-Gau Remi-Gau linked an issue Oct 5, 2020 that may be closed by this pull request
@marcobarilari
Copy link
Collaborator

it works for me :) thanks

@CerenB
Copy link
Collaborator

CerenB commented Oct 5, 2020

yep, works for me too!

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Oct 5, 2020

🚀 🎉

Thanks @CerenB for not letting go!

Thanks @marcobarilari for the help on the bug hunt!

#TeamWork

@Remi-Gau Remi-Gau merged commit d332562 into cpp-lln-lab:dev Oct 5, 2020
@Remi-Gau Remi-Gau deleted the remi-change_read_filter_save branch October 13, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inccorect saved ouput by readAndFilterLogfile

3 participants