-
Notifications
You must be signed in to change notification settings - Fork 9
update bids validator version in CI #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bids validator version in CI #112
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #112 +/- ##
==========================================
+ Coverage 79.90% 81.00% +1.10%
==========================================
Files 28 29 +1
Lines 602 616 +14
==========================================
+ Hits 481 499 +18
+ Misses 121 117 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Tagging @CerenB as you are the one who has started using I will adap the code to follow the specifications and then we can see how to adapt the code of your experiment to see how we can make everyone happy. 😄 |
|
ok! Did you make changes already? Because under this PR there are 2.2K changes apparently. Should I check the |
|
hum... Let me fix that horrendous number of file changes. (I had commited some node.js files before for the checking the markdown stuff...) |
|
OK this should be more bearable to review now. 😉 To explain the changes. Official BIDS The stim file must then be a time series with a new entry at regular time interval. That's why the data dictionary for those stim files must have a "sampling frequency" key (will add a comment after this post). (And also why there is a Another difference with All of this is for a RAW BIDS dataset, obvisouly you can do whatever you want in your SOURCE data, but ideally you want to make your life easier when converting your SOURCE into RAW. So IF you want to have the information that you currently put into those stim files in your raw BIDS data, then it might not be the most convenient for you: you would need to add a row (say every second) to say what was going on during your experiment at this time point. What you can do in your source data is record all the things you were putting in your stim file into a second events file: it should be fairly easy to do and we can make CPP_BIDS do that for you without any further change. Another possibility for you is to log all the info into a single events file but if I remember you wanted to avoid that because it would mean logging tons of "extra" stuff in there. Does that make sense? If not let me know and can hop on a video chat to talk about this. |
| namesExtraColumns = returnNamesExtraColumns(logFile); | ||
| if ismember('_stim', fullFilename) | ||
|
|
||
| samplingFrequency = nan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are initializing a stim file we need to specify the sampling frequency in the data dictionnary.
|
interesting... I am ok with both options that you mentioned: What you can do in your source data is record all the things you were putting in your stim file into a second events file: it should be fairly easy to do and we can make CPP_BIDS do that for you without any further change. Another possibility for you is to log all the info into a single events file but if I remember you wanted to avoid that because it would mean logging tons of "extra" stuff in there._ At the end all I do is to look at what you pressed is actually the same count as the target presented throughout the experiment. It does not need to be in |
yes it should be quite simple to do. I will try to add an example in the jupyter notebook folder |
|
Here is a quick demo. Let me know if this is good enough or if I should mention something else. |
|
Cool! thank you for this. |
Yes you are correct the BIDS validator will not be happy because there will be an events file with no corresponding bold file. EXCEPT for purely behavioral files where it won't expect a corresponding bold file. so if you set
Then the outpute would be saved in the |
Problem.
stim files JSON must include the following:
{ "SamplingFrequency": 100.0, "StartTime": -22.345, "Columns": ["cardiac", "respiratory", "trigger"], "cardiac": { "Units": "mV" } }https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/06-physiological-and-other-continuous-recordings.html#physiological-and-other-continuous-recordings