Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Nov 16, 2020

TODO

  • describe content and use of cfg in rst doc
  • describe what checkCFG does in the help section

@Remi-Gau Remi-Gau added the documentation Improvements or additions to documentation label Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #125 (460ec45) into doc (cc99e1e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              doc     #125      +/-   ##
==========================================
- Coverage   81.00%   80.97%   -0.04%     
==========================================
  Files          29       29              
  Lines         616      615       -1     
==========================================
- Hits          499      498       -1     
  Misses        117      117              
Flag Coverage Δ
unittests 80.97% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/transferInfoToBids.m 100.00% <ø> (ø)
src/checkCFG.m 98.82% <100.00%> (-0.02%) ⬇️
src/userInputs.m 0.00% <0.00%> (ø)
src/gui/askUserCli.m 0.00% <0.00%> (ø)
src/gui/askUserGui.m 0.00% <0.00%> (ø)
src/createDataDictionary.m 100.00% <0.00%> (ø)
src/gui/createQuestionList.m 100.00% <0.00%> (ø)
src/gui/getIsQuestionToAsk.m 100.00% <0.00%> (ø)
src/utils/removeDateSuffix.m 90.90% <0.00%> (ø)
src/gui/setDefaultResponses.m 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb55a1...01c0736. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

@CerenB @marcobarilari
I still need to update the actual sphinx documentation related to cfg. But you can already start looking into the new and "very small" help section of checkCFG.

Copy link
Collaborator

@marcobarilari marcobarilari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Remi-Gau
Copy link
Contributor Author

@marcobarilari @CerenB

I updated the index.rst and created a set_up.rst and tried to move some of the content that was in the markdown in there.

Maybe have a look and let me know what you think.

@marcobarilari
Copy link
Collaborator

overall LGTM

@Remi-Gau
Copy link
Contributor Author

overall LGTM

OK will merge then. I am fighting hard my inner perfectionist to keep improving this.

At least all of that gives us a better base to start from in general.

@Remi-Gau Remi-Gau merged commit 86fab40 into cpp-lln-lab:doc Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants