Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

Some tests stopped run on Travis but were fine locally.

Attempting to fix that here.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #144 (d307851) into dev (91b2260) will increase coverage by 2.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #144      +/-   ##
==========================================
+ Coverage   78.67%   80.68%   +2.00%     
==========================================
  Files          29       29              
  Lines         647      647              
==========================================
+ Hits          509      522      +13     
+ Misses        138      125      -13     
Flag Coverage Δ
unittests 80.68% <ø> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/createDataDictionary.m 100.00% <0.00%> (+13.63%) ⬆️
src/createJson.m 65.85% <0.00%> (+14.63%) ⬆️
src/createDatasetDescription.m 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cda77c...ec73e90. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

OK this is a REALLY dirty temporary hack where the tests return after having run the functions they are supposed to tests but before they actually check the content.

This is basically now just a "smoke test". Better than nothing but it leaves much to be desired.

Incriminated tests:

  • test_createDataDictionaryBasic
  • test_createDataDictionaryStim
  • test_createJsonExtra

Pasting here the content of the failed CI and will reference this in another issue so we know this has to be improved.

See https://github.com/cpp-lln-lab/CPP_BIDS/pull/144/checks?check_run_id=1411109386

failure: /github/workspace/lib/JSONio/jsonread.mex: failed to load: liboctinterp.so.4: cannot open shared object file: No such file or directory
  jsondecode:27 (/github/workspace/lib/bids-matlab/+bids/+util/jsondecode.m)
  test_createDataDictionary>test_createDataDictionaryBasic:57 (/github/workspace/tests/test_createDataDictionary.m)

failure: /github/workspace/lib/JSONio/jsonread.mex: failed to load: liboctinterp.so.4: cannot open shared object file: No such file or directory
  jsondecode:27 (/github/workspace/lib/bids-matlab/+bids/+util/jsondecode.m)
  test_createDataDictionary>test_createDataDictionaryStim:123 (/github/workspace/tests/test_createDataDictionary.m)

failure: /github/workspace/lib/JSONio/jsonread.mex: failed to load: liboctinterp.so.4: cannot open shared object file: No such file or directory
  jsondecode:27 (/github/workspace/lib/bids-matlab/+bids/+util/jsondecode.m)
  test_createJson>test_createJsonExtra:158 (/github/workspace/tests/test_createJson.m)

@Remi-Gau Remi-Gau merged commit 08d3659 into cpp-lln-lab:dev Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant