Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Dec 24, 2020

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #158 (d8d4c5d) into release_candidate_2.0 (387e14d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           release_candidate_2.0     #158   +/-   ##
======================================================
  Coverage                  79.90%   79.90%           
======================================================
  Files                         30       30           
  Lines                        652      652           
======================================================
  Hits                         521      521           
  Misses                       131      131           
Flag Coverage Δ
unittests 79.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/checkCFG.m 98.82% <ø> (ø)
src/templates/test_templateTest.m 0.00% <ø> (ø)
src/utils/checkCppBidsDependencies.m 33.33% <ø> (ø)
src/utils/printCreditsCppBids.m 96.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387e14d...d8d4c5d. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

Need to refactor saveToLogFile

src/saveEventsFile.m: metric: exceeded file_length: measured 522 > limit 500
In src/saveEventsFile.m, line 345
| function logFile = saveToLogFile(logFile, cfg)
|                    ^^^^^^^^^^^^^ metric: exceeded cyc: measured 17 > limit 15
MISS_HIT Metric Summary: 53 file(s) analysed, 2 metric deviations(s)
Error: Process completed with exit code 1.

@Remi-Gau Remi-Gau mentioned this pull request Dec 24, 2020
@Remi-Gau Remi-Gau merged commit 9a57c2e into cpp-lln-lab:release_candidate_2.0 Dec 24, 2020
@Remi-Gau Remi-Gau deleted the remi-update_miss_hit branch December 24, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant