-
Notifications
You must be signed in to change notification settings - Fork 9
Refactoring #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #42
Conversation
- MRI - dataset description
- also do some linting
|
heya! sorry that i'm falling behind a bit with these light speed PRs :) |
|
testing is not working for me. when I manually provide the pth as the current directory, it still fails. What am I doing wrong? |
yes that's correct.
Same for |
@CerenB what is the error message? |
|
@Remi-Gau I think the error was Ceren didn't have enough coffee. Because now it works! Sorry to bother you with this error. I took care of it. |
no big changes
mostly cleaning code and breaking things into smaller sub-functions.
most noticeable change:
cfgandexpParametersif running a fairly normal thing.checkCFGascreateFilenamedoes it for you.cfgANDexpParametersto be returned bycreateFilenamelike this:testsfolder to make them easier to understand how to use all of this