Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

Rewrote the function so it should be easier to use in general.

Need to add some doc and break the unit test into several functions.

But you can start having a look.

@Remi-Gau Remi-Gau requested review from CerenB and marcobarilari July 21, 2020 13:24
Copy link
Collaborator

@CerenB CerenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow!

@Remi-Gau
Copy link
Contributor Author

Documentation has been updated so unless I hear some major complaint I will merge in 24 hours. :-)

@Remi-Gau
Copy link
Contributor Author

fix #38 #43

@Remi-Gau Remi-Gau merged commit 0f968f8 into cpp-lln-lab:master Jul 22, 2020
@Remi-Gau Remi-Gau deleted the remi-simplify_saveEvents branch July 25, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants