-
Notifications
You must be signed in to change notification settings - Fork 9
Simplify save events #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Remi-Gau
merged 11 commits into
cpp-lln-lab:master
from
Remi-Gau:remi-simplify_saveEvents
Jul 22, 2020
Merged
Simplify save events #44
Remi-Gau
merged 11 commits into
cpp-lln-lab:master
from
Remi-Gau:remi-simplify_saveEvents
Jul 22, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CerenB
approved these changes
Jul 21, 2020
Collaborator
CerenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow!
Contributor
Author
|
Documentation has been updated so unless I hear some major complaint I will merge in 24 hours. :-) |
Contributor
Author
marcobarilari
approved these changes
Jul 21, 2020
CerenB
approved these changes
Jul 22, 2020
- can now have checkCFG.m and not only checkCfg.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the function so it should be easier to use in general.
Need to add some doc and break the unit test into several functions.
But you can start having a look.