Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jul 22, 2020

This adds new functions to create a JSON side-car files and a high level integration test to make sure we can generate a valid BIDS dataset.

  • this required quite a bit of refactoring by exposing some subfunctions from saveEvents (added in the subfun folder)
  • added quite a few tests
  • added JSONio and bids-matlab as dependencies via submodules

@Remi-Gau Remi-Gau marked this pull request as ready for review July 23, 2020 15:55
@marcobarilari
Copy link
Collaborator

not close related to this PR, but I tried running the runTests function, how is it possible that mfilename('fullpath') gives as answer 0×0 empty char array?

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jul 23, 2020 via email

@CerenB
Copy link
Collaborator

CerenB commented Jul 24, 2020

Yup, I had the same issue. You gotta put things into path and run in function.

@Remi-Gau Remi-Gau merged commit b01eb2e into cpp-lln-lab:master Jul 25, 2020
@Remi-Gau Remi-Gau deleted the remi-JSON_output branch July 25, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants