Skip to content

Conversation

@CerenB
Copy link
Collaborator

@CerenB CerenB commented Jul 27, 2020

all the expParams are converted into cfg.

  • passes all the tests.
  • still needs sub-fields in structure of cfg
  • mh_style found some white space issues but also includes some that cannot be fixed.

@CerenB CerenB requested review from Remi-Gau and marcobarilari July 27, 2020 22:05
Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we are good to go.

Will merge and update readme and doc in a separate PR.

@Remi-Gau Remi-Gau merged commit 4077957 into cpp-lln-lab:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants