Skip to content

Conversation

@CerenB
Copy link
Collaborator

@CerenB CerenB commented Aug 4, 2020

it's a tiny modification in submodule example.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files          17       17           
  Lines         396      396           
=======================================
  Hits          299      299           
  Misses         97       97           
Flag Coverage Δ
#unittests 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b3e7...41cc9ee. Read the comment docs.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Aug 4, 2020

@CerenB we can merge, unless you want to add something more?

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Aug 4, 2020

Added some changes directly to the field for subject info

Copy link
Collaborator Author

@CerenB CerenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup good to go!

@CerenB CerenB merged commit cae3276 into cpp-lln-lab:master Aug 4, 2020
@CerenB CerenB deleted the typo_README_ceren branch November 16, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants