Skip to content

Conversation

@CerenB
Copy link
Collaborator

@CerenB CerenB commented Sep 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          26       26           
  Lines         550      550           
=======================================
  Hits          435      435           
  Misses        115      115           
Flag Coverage Δ
#unittests 79.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3c9bf...00adc35. Read the comment docs.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a typo to fix

3. Download the [Anaconda Installer](https://www.anaconda.com/products/individual) and install it.
4. Install [Octave kernel](https://pypi.org/project/octave-kernel/):
If using miniconda, run `conda install jupyter` to download and install the Jupyter Notebook package.
4. Install [Octave kernel](https://pypi.org/project/octave-kernel/):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try all these steps in the brand 'new' old mac to see if it works and if there are faster ways like installing stuff e.g. via homebrew.

Related to this, I fear that these installing steps can be done in different (and faster) ways depending on the OS. What do you think?

Worth to point to different ways depending on the OS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think anaconda/conda provide very good support on the issue. We should not spend time on it thaaaat much.
I've tried these with my mac, thus I added the tiny suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best way is to point to other doc where they have that nailed already but I agree that for OS specific info is nice.

I think I had taken that from Agah's repo from the OHBM hackathon.

Maybe we have some more install info on the hackathon website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in general I would have an approach of "some doc is better than none and update it when someone points out it is not clear".

1. Make sure that you have Octave installed.
1. Make sure that you have Octave installed.
2. If you have Conda/Jupyter/pip installed, go to step 4.
Check is Conda installed properly by `conda list` typing into your terminal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I have the 'Anaconda navigator app' installed but if I tyoe conda list the terminal says tha does not know the conda command

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok somehow re installing Anaconda worked

Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@marcobarilari
Copy link
Collaborator

I think this one is ready to be merged, what you think?

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Oct 5, 2020

@CerenB

I will reopen this one to have as a PR on dev and not on master. Sorry about that. :-)

@Remi-Gau Remi-Gau mentioned this pull request Oct 5, 2020
@Remi-Gau Remi-Gau closed this Oct 5, 2020
@CerenB CerenB deleted the cer-readme_suggest branch November 16, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants