Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #99 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #99   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          26       26           
  Lines         550      550           
=======================================
  Hits          435      435           
  Misses        115      115           
Flag Coverage Δ
#unittests 79.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/checkCFG.m 98.64% <ø> (ø)
src/convertSourceToRaw.m 0.00% <ø> (ø)
src/createDatasetDescription.m 0.00% <ø> (ø)
src/createFilename.m 95.89% <ø> (ø)
src/createJson.m 51.21% <ø> (ø)
src/saveEventsFile.m 94.16% <ø> (ø)
src/subfun/askUserGui.m 0.00% <ø> (ø)
src/subfun/checkCppBidsDependencies.m 50.00% <ø> (ø)
src/subfun/initializeExtraColumns.m 100.00% <ø> (ø)
src/subfun/isPositiveInteger.m 100.00% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1efc29...942a08a. Read the comment docs.

@Remi-Gau
Copy link
Contributor Author

fix #98

@Remi-Gau
Copy link
Contributor Author

@ceren I will merge this on the dev branch so make sure that you have your own "dev" branch to track and use it.

@Remi-Gau
Copy link
Contributor Author

OK a couple of things are failing but it seems they are linting issue due to the new miss_hit linter.

Will merge that now and fix later (famous last words)

@Remi-Gau Remi-Gau merged commit 82efd6f into cpp-lln-lab:dev Sep 23, 2020
@Remi-Gau Remi-Gau deleted the remi-event_stim_log branch September 27, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants