Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

No description provided.

@marcobarilari marcobarilari added enhancement New feature or request priority 1 High priority labels Sep 23, 2020
@marcobarilari marcobarilari marked this pull request as draft September 23, 2020 09:47
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #106 into dev will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #106      +/-   ##
==========================================
- Coverage   25.81%   25.73%   -0.09%     
==========================================
  Files          44       44              
  Lines         643      645       +2     
==========================================
  Hits          166      166              
- Misses        477      479       +2     
Flag Coverage Δ
#unittests 25.73% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eyeTracker.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa1f86...c93313f. Read the comment docs.

@marcobarilari
Copy link
Collaborator Author

resolves #84

@marcobarilari
Copy link
Collaborator Author

I think those few lines will do what we need to tag the ET output

@marcobarilari marcobarilari marked this pull request as ready for review September 23, 2020 15:51
@marcobarilari
Copy link
Collaborator Author

marcobarilari commented Sep 23, 2020

I guess that Travis is complaining because of the new release of miss_hit, @Remi-Gau let me know how you want to manage this at the repo level.

Easily, I can do it in this pr but we lose a bit of of congruety between pr title and what it really does OR I (or anyonelse) can do it in a separate branch of dev and then I rebase this pr with dev and we merge this one with only the changes regarding the ET.

LMK

@Remi-Gau
Copy link
Contributor

you're right let's focus on the content of this PR.
we'll fix the style in another one.
or maybe just fix the style only of the files you have changed already.

@Remi-Gau
Copy link
Contributor

I think miss_hit can do this

mh_style filename.m --fix

@marcobarilari
Copy link
Collaborator Author

done already 🤓

if I remember well, if travis fails merge is blocked, am I right?

@Remi-Gau
Copy link
Contributor

nope : you as an admin can override it as long as it is on the dev branch

@Remi-Gau
Copy link
Contributor

let me rephrase that: NOW that have made you admin and not "just" maintainer you CAN do that. :-)

@Remi-Gau
Copy link
Contributor

OK I will review this first. Because the code styling can be automated more easily.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup this looks good to me.

that will help us.

@Remi-Gau
Copy link
Contributor

merging and then will check the next PR

@Remi-Gau Remi-Gau merged commit 07f68ef into cpp-lln-lab:dev Sep 23, 2020
@marcobarilari marcobarilari deleted the marco_ET-message-tag branch September 26, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority 1 High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants