-
Notifications
You must be signed in to change notification settings - Fork 13
EyeTracker - add switch case to record a 'message' (tag) in the output #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #106 +/- ##
==========================================
- Coverage 25.81% 25.73% -0.09%
==========================================
Files 44 44
Lines 643 645 +2
==========================================
Hits 166 166
- Misses 477 479 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
resolves #84 |
|
I think those few lines will do what we need to tag the ET output |
|
I guess that Travis is complaining because of the new release of Easily, I can do it in this pr but we lose a bit of of congruety between pr title and what it really does OR I (or anyonelse) can do it in a separate branch of LMK |
|
you're right let's focus on the content of this PR. |
|
I think miss_hit can do this |
|
done already 🤓 if I remember well, if travis fails merge is blocked, am I right? |
|
nope : you as an admin can override it as long as it is on the |
|
let me rephrase that: NOW that have made you admin and not "just" maintainer you CAN do that. :-) |
|
OK I will review this first. Because the code styling can be automated more easily. |
Remi-Gau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup this looks good to me.
that will help us.
|
merging and then will check the next PR |
No description provided.