Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #110 into dev will increase coverage by 3.97%.
The diff coverage is 80.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #110      +/-   ##
==========================================
+ Coverage   25.42%   29.39%   +3.97%     
==========================================
  Files          44       47       +3     
  Lines         653      694      +41     
==========================================
+ Hits          166      204      +38     
- Misses        487      490       +3     
Flag Coverage Δ
#unittests 29.39% <80.24%> (+3.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/aperture/apertureTexture.m 0.00% <0.00%> (ø)
src/dot/computeCartCoord.m 100.00% <ø> (ø)
src/dot/dotTexture.m 0.00% <0.00%> (ø)
src/utils/degToPix.m 100.00% <ø> (ø)
src/dot/dotMotionSimulation.m 70.45% <70.45%> (ø)
src/dot/computeRadialMotionDirection.m 80.00% <100.00%> (ø)
src/dot/generateNewDotPositions.m 100.00% <100.00%> (ø)
src/dot/initDots.m 100.00% <100.00%> (ø)
src/dot/reseedDots.m 100.00% <100.00%> (ø)
src/dot/seedDots.m 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199069e...5a6dc1e. Read the comment docs.

title('dot density');
end

fprintf(1, '\n');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's that?

@marcobarilari
Copy link
Collaborator

very nice, LGTM and ready to be merged. I don't suggest to add stuff in the docs cause some automation will come (right?)

@marcobarilari
Copy link
Collaborator

marcobarilari commented Sep 29, 2020

btw, is cpp-lln-lab/localizer_visual_motion#4 fixed by this pr?

@Remi-Gau Remi-Gau added the priority 1 High priority label Sep 30, 2020
@Remi-Gau
Copy link
Contributor Author

btw, is cpp-lln-lab/localizer_visual_motion#4 fixed by this pr?

yes this should be a bit of a hacky fix to this issue.

not super clean but at least we have now a way to vizualize the result

@Remi-Gau
Copy link
Contributor Author

very nice, LGTM and ready to be merged. I don't suggest to add stuff in the docs cause some automation will come (right?)

hopefully this should come soon !

@Remi-Gau Remi-Gau merged commit 95f750e into dev Sep 30, 2020
@Remi-Gau Remi-Gau deleted the remi-radial_motion branch October 6, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority 1 High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants