Skip to content

update how PTB opens a window to the easiest way #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2020
Merged

update how PTB opens a window to the easiest way #26

merged 4 commits into from
Jul 17, 2020

Conversation

@marcobarilari
Copy link
Collaborator

@marcobarilari marcobarilari commented Jul 15, 2020 •
edited
Loading

resolves #25

@marcobarilari marcobarilari added enhancement New feature or request good first issue Good for newcomers labels Jul 15, 2020
@marcobarilari marcobarilari removed the request for review from Remi-Gau July 15, 2020 20:53
Remi-Gau
Remi-Gau approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Will have to check of some of the repo we use that one do not start breakinb afer this merge.

But for now we can merget this IMHO.

@Remi-Gau Remi-Gau mentioned this pull request Jul 16, 2020
Merged
CerenB
CerenB approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@CerenB CerenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jul 17, 2020

@marcobarilari Should I merge?
I will then transfer my PR from your repo to this one.

@marcobarilari
Copy link
Collaborator Author

marcobarilari commented Jul 17, 2020

@marcobarilari Should I merge?
I will then transfer my PR from your repo to this one.

Sorry! forgot to merge :) here you go

@marcobarilari marcobarilari merged commit 81521c0 into cpp-lln-lab:master Jul 17, 2020
@marcobarilari marcobarilari deleted the marco_screen-open-w branch July 17, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Remi-Gau Remi-Gau Remi-Gau approved these changes

@CerenB CerenB CerenB approved these changes

@fedefalag fedefalag Awaiting requested review from fedefalag

Assignees

No one assigned

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move from from PsychImaging to Screen to open a PTB window (initPTB.m)

3 participants

@marcobarilari @Remi-Gau @CerenB