Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

No description provided.

@marcobarilari marcobarilari requested a review from Remi-Gau July 17, 2020 17:26
@marcobarilari marcobarilari added the enhancement New feature or request label Jul 17, 2020
@marcobarilari
Copy link
Collaborator Author

I add that some comments and many other explanations about what is really happening there + is really the best way to use an ET are missing.

After your check, I would merge to speed up the process and #32 will remind me to do it in the future

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I am going to approve this for now and we will improve on it as we go. Bit by bit.

It is too abstract for me now. 😄

@Remi-Gau Remi-Gau merged commit 6b989e3 into cpp-lln-lab:master Jul 17, 2020
@marcobarilari
Copy link
Collaborator Author

It is too abstract for me now. 😄

same here

@marcobarilari marcobarilari deleted the marco_eyeTracker branch July 17, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants