Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

Just a simple upgrade to this stand alone func. Pushing this here before moving it out in the new repo

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files          41       41           
  Lines         627      627           
=======================================
  Hits           91       91           
  Misses        536      536           
Flag Coverage Δ
#unittests 14.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae1304...4a996e8. Read the comment docs.

@Remi-Gau
Copy link
Contributor

Actually if the idea is to have a template repo for PTB experiment with CPP_PTB already set up as a submodule, you will not need to have sub-functions specific to this function like the devSandBoxppd, no?

@marcobarilari
Copy link
Collaborator Author

true! good point

@marcobarilari marcobarilari merged commit a402b14 into cpp-lln-lab:master Sep 10, 2020
@marcobarilari marcobarilari deleted the marco_improve-devSandbox branch September 11, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants