Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

Very simple scripts to gzip any .nii file a raw folder. Any suggestion on how to make them smarter and how they are organize in the repo struct is welcome.

@marcobarilari marcobarilari linked an issue Nov 12, 2020 that may be closed by this pull request
@marcobarilari marcobarilari requested review from CerenB and Remi-Gau and removed request for CerenB and Remi-Gau November 12, 2020 14:21
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #179 (eefa8ae) into dev (caab30c) will increase coverage by 0.48%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #179      +/-   ##
==========================================
+ Coverage   44.66%   45.15%   +0.48%     
==========================================
  Files          94       96       +2     
  Lines        1679     1694      +15     
==========================================
+ Hits          750      765      +15     
  Misses        929      929              
Impacted Files Coverage Δ
src/batches/setBatch3Dto4D.m 0.00% <ø> (ø)
src/batches/setBatchGZip.m 0.00% <0.00%> (ø)
src/workflows/bidsGZipRawFolder.m 0.00% <0.00%> (ø)
src/defaults/checkOptionsSource.m 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caab30c...eefa8ae. Read the comment docs.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. 🚀

Just realized that an easier function to write a test for is the checkOptionsSource.m .

You can clearly inspire yourself from the one written for checkOptions. 😉

marcobarilari and others added 7 commits November 13, 2020 10:45
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
@marcobarilari
Copy link
Collaborator Author

add a test for checkOptionSource

run on my computer and it saved ~500MB on a 3GB dataset so, around the ~15% of space saved. I do not know though if it is a linear equation.

LMK

@Remi-Gau
Copy link
Contributor

add a test for checkOptionSource

And it passes and all !!! :-)

Could you run it locally with MOxUnit ? I suspect we will need some doc about that too.

run on my computer and it saved ~500MB on a 3GB dataset so, around the ~15% of space saved. I do not know though if it is a linear equation.

I doubt it is linear. It very much depends on what you are zipping.

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to go!

Press the big green button when you want.

@Remi-Gau Remi-Gau marked this pull request as ready for review November 13, 2020 12:06
@marcobarilari
Copy link
Collaborator Author

Could you run it locally with MOxUnit ? I suspect we will need some doc about that too.

You mean the script runTests? It does not work because I think I have to set the MOxUnit on my computer and I haven't done it yet. But yes +1 for adding docs about that

@marcobarilari marcobarilari merged commit 34aded3 into cpp-lln-lab:dev Nov 13, 2020
@marcobarilari marcobarilari deleted the marco_zip-raw-folder branch November 13, 2020 12:20
@Remi-Gau
Copy link
Contributor

Actually to run all the tests you "simply" need to be in the tests folder and run moxunit_runtests.

But it does require you to install MOxUnit. Easier than it sounds. :-)

@Remi-Gau
Copy link
Contributor

@all-contributors please add @marcobarilari for test

@allcontributors
Copy link
Contributor

@Remi-Gau

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 412

@Remi-Gau
Copy link
Contributor

let's try again

@all-contributors please add @marcobarilari for test

@allcontributors
Copy link
Contributor

@Remi-Gau

I've put up a pull request to add @marcobarilari! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Workflow for zipping a raw folder content

2 participants