-
Notifications
You must be signed in to change notification settings - Fork 15
[ENH] add gzip scripts for raw folder #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add gzip scripts for raw folder #179
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #179 +/- ##
==========================================
+ Coverage 44.66% 45.15% +0.48%
==========================================
Files 94 96 +2
Lines 1679 1694 +15
==========================================
+ Hits 750 765 +15
Misses 929 929
Continue to review full report at Codecov.
|
Remi-Gau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. 🚀
Just realized that an easier function to write a test for is the checkOptionsSource.m .
You can clearly inspire yourself from the one written for checkOptions. 😉
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
|
add a test for run on my computer and it saved ~500MB on a 3GB dataset so, around the ~15% of space saved. I do not know though if it is a linear equation. LMK |
And it passes and all !!! :-) Could you run it locally with MOxUnit ? I suspect we will need some doc about that too.
I doubt it is linear. It very much depends on what you are zipping. |
Remi-Gau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are good to go!
Press the big green button when you want.
You mean the script |
|
Actually to run all the tests you "simply" need to be in the But it does require you to install MOxUnit. Easier than it sounds. :-) |
|
@all-contributors please add @marcobarilari for test |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 412 |
|
let's try again @all-contributors please add @marcobarilari for test |
|
I've put up a pull request to add @marcobarilari! 🎉 |
Very simple scripts to gzip any
.niifile a raw folder. Any suggestion on how to make them smarter and how they are organize in the repo struct is welcome.