Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 16, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.19%.

Quality metrics Before After Change
Complexity 5.25 ⭐ 5.02 ⭐ -0.23 👍
Method Length 67.76 🙂 64.02 🙂 -3.74 👍
Working memory 6.36 🙂 6.17 ⭐ -0.19 👍
Quality 71.60% 🙂 72.79% 🙂 1.19% 👍
Other metrics Before After Change
Lines 926 951 25
Changed files Quality Before Quality After Quality Change
bidsmreye/bidsmreye.py 58.39% 🙂 57.82% 🙂 -0.57% 👎
bidsmreye/download.py 69.91% 🙂 67.98% 🙂 -1.93% 👎
bidsmreye/utils.py 74.00% 🙂 74.52% 🙂 0.52% 👍
tests/test_download.py 93.19% ⭐ 92.70% ⭐ -0.49% 👎
tests/test_methods.py 93.85% ⭐ 94.02% ⭐ 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/bidsmreye.py cli 16 🙂 243 ⛔ 10 😞 40.77% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.check_argument 11 🙂 177 😞 9 🙂 51.74% 🙂 Try splitting into smaller methods
bidsmreye/utils.py Config.__attrs_post_init__ 9 🙂 214 ⛔ 7 🙂 55.23% 🙂 Try splitting into smaller methods
bidsmreye/utils.py check_layout 9 🙂 148 😞 9 🙂 56.40% 🙂 Try splitting into smaller methods
bidsmreye/download.py download 9 🙂 168 😞 8 🙂 56.60% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #97 (786bd34) into main (4e58b60) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main     #97   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        524     536   +12     
=====================================
- Misses       524     536   +12     
Flag Coverage Δ
tests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bidsmreye/bidsmreye.py 0.00% <0.00%> (ø)
bidsmreye/download.py 0.00% <0.00%> (ø)
bidsmreye/utils.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit 8bc9d75 into cpp-lln-lab:main Dec 16, 2022
@Remi-Gau Remi-Gau deleted the download branch December 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant