Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Oct 19, 2020

No description provided.

@Remi-Gau Remi-Gau linked an issue Oct 19, 2020 that may be closed by this pull request
@Remi-Gau
Copy link
Contributor Author

@CerenB
this should help us to "flexibly" open a graph window and then saves its ouput in the func directory

@Remi-Gau
Copy link
Contributor Author

the few changes in src/spmBatching/bidsSpatialPrepro.m show how to use it.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #119 into dev will decrease coverage by 0.46%.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #119      +/-   ##
==========================================
- Coverage   44.59%   44.12%   -0.47%     
==========================================
  Files          79       81       +2     
  Lines        1581     1600      +19     
==========================================
+ Hits          705      706       +1     
- Misses        876      894      +18     
Impacted Files Coverage Δ
src/reports/copyGraphWindownOutput.m 0.00% <0.00%> (ø)
src/utils/setGraphicWindow.m 0.00% <0.00%> (ø)
src/workflows/bidsSegmentSkullStrip.m 0.00% <ø> (ø)
src/workflows/bidsSpatialPrepro.m 0.00% <0.00%> (ø)
src/defaults/spm_my_defaults.m 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ca082...c062bdf. Read the comment docs.

Copy link
Collaborator

@CerenB CerenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I'll try it after today's new data collection!
I think test_setBatchRealign.m had changed with your realign PR. Interesting that in this PR, it does not update?

@Remi-Gau
Copy link
Contributor Author

nice! I'll try it after today's new data collection!
I think test_setBatchRealign.m had changed with your realign PR. Interesting that in this PR, it does not update?

I am doing PRs in parallel.

Because they touch on different parts of the code, I don't want to build them 'one on top of the other" because otherwise you get into merge conflicts or you need to do some annoying cross-PR rebase and other kind of "git fuckery magic".

Another advantage of having very modular code. You can work on different modules "at the same time" and not get into horrible merge conflicts.

@Remi-Gau Remi-Gau changed the title launch graphic windows and save output to func directory [ENH] launch graphic windows and save output to func directory Oct 30, 2020
@Remi-Gau Remi-Gau added this to the v0.1.0 milestone Oct 31, 2020
@Remi-Gau
Copy link
Contributor Author

function imgNb = copyGraphWindownOutput(opt, subID, action, imgNb)
  %
  % Looks into the current directory for an spm_.*imgNb.png file and moves it into
  % the output directory ``sub-label/figures``.
  % The output name of the file is
  % ``yyyymmddHHMM_sub-label_task-label_action.png``
  %
  % USAGE::
  %
  %   imgNb = copyGraphWindownOutput(opt, subID, [action = '',] [imgNb = 1])
  %
  % :param opt: options
  % :type opt: structure
  % :param subID:
  % :type subID: string
  % :param action:
  % :type action: string
  % :param imgNb: image number to look for. SPM increments them automatically.
  % :type imgNb: integer
  %
  % :returns: - :imgNb: (integer) number of the next image to get.
  %
  % assumes that no file was generated if SPM is running in command line mode

@Remi-Gau Remi-Gau merged commit 4deda58 into cpp-lln-lab:dev Oct 31, 2020
@Remi-Gau Remi-Gau deleted the remi-graph_window branch November 6, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

saving spatial preprocessing spm graphs/ figures

2 participants