-
Notifications
You must be signed in to change notification settings - Fork 15
[ENH] launch graphic windows and save output to func directory #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CerenB |
|
the few changes in |
Codecov Report
@@ Coverage Diff @@
## dev #119 +/- ##
==========================================
- Coverage 44.59% 44.12% -0.47%
==========================================
Files 79 81 +2
Lines 1581 1600 +19
==========================================
+ Hits 705 706 +1
- Misses 876 894 +18
Continue to review full report at Codecov.
|
CerenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I'll try it after today's new data collection!
I think test_setBatchRealign.m had changed with your realign PR. Interesting that in this PR, it does not update?
I am doing PRs in parallel. Because they touch on different parts of the code, I don't want to build them 'one on top of the other" because otherwise you get into merge conflicts or you need to do some annoying cross-PR rebase and other kind of "git Another advantage of having very modular code. You can work on different modules "at the same time" and not get into horrible merge conflicts. |
11431f7 to
b895114
Compare
b895114 to
b364e05
Compare
|
No description provided.