Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 15, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (f53979a) to head (43605e0).
Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   79.57%   77.87%   -1.71%     
==========================================
  Files         285      291       +6     
  Lines        7742     7904     +162     
  Branches       40       50      +10     
==========================================
- Hits         6161     6155       -6     
- Misses       1565     1749     +184     
+ Partials       16        0      -16     
Flag Coverage Δ
cli 0.00% <ø> (-39.00%) ⬇️
macos-13_matlab-R2023b_fast 60.53% <ø> (?)
macos-13_matlab-R2023b_slow 58.36% <ø> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.46% <ø> (+0.74%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 60.53% <ø> (?)
ubuntu-latest_matlab-R2023b_slow 58.35% <ø> (?)
windows-latest_matlab-R2023b_fast 60.53% <ø> (?)
windows-latest_matlab-R2023b_slow 58.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcobarilari
Copy link
Collaborator Author

marcobarilari commented Jul 15, 2024

fix #1288

given that I only modified a readme file I doubt that the tests are failing by my fault 😇

@Remi-Gau Remi-Gau merged commit cc857b7 into cpp-lln-lab:main Jul 15, 2024
@marcobarilari marcobarilari deleted the maco_fix_#1288 branch July 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants