-
Notifications
You must be signed in to change notification settings - Fork 15
[MAINT] update bids-matlab submodule #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the bids-matlab submodule, adds a GitHub Actions workflow for generating changelogs, and includes a test file for changelog generation. The submodule update ensures the project uses the correct version of the bids-matlab library. The changelog workflow automates the generation of changelogs based on commit history. The test file was added to test the changelog generation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcobarilari - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider whether the conditional logic in the changelog workflow can be simplified for readability.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/changelog.yml
Outdated
| - name: Run changelog builder | ||
| run: if (git log -1 --pretty=%s | grep Merge*) && (! git log -1 --pretty=%b | grep REL:) ; then | ||
|
|
||
| github_changelog_generator --user cpp-lln-lab --project CPP-SPM --token ${CHANGE_TOKEN} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Quote the CHANGE_TOKEN variable in the command.
To avoid issues if the token contains special characters or spaces, wrap ${CHANGE_TOKEN} in double quotes.
| github_changelog_generator --user cpp-lln-lab --project CPP-SPM --token ${CHANGE_TOKEN} \ | |
| github_changelog_generator --user cpp-lln-lab --project CPP-SPM --token "${CHANGE_TOKEN}" \ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
+ Coverage 79.57% 81.75% +2.17%
==========================================
Files 285 284 -1
Lines 7742 7746 +4
Branches 40 0 -40
==========================================
+ Hits 6161 6333 +172
+ Misses 1565 1413 -152
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated submodule and '.gitmodule' file that was pointing to 'dev' branch
Summary by Sourcery
Updates the bids-matlab submodule and adds a CI workflow to generate a changelog file.
Build:
CI:
Tests: