Skip to content

Conversation

@Remi-Gau
Copy link
Contributor

This should address #177

  • copyGraphWindowOutput will throw warning if it finds no file or more than one file to copy and will throw a warning in those cases but it won't crash.

@CerenB Can you check if this branch solves your issues.

@Remi-Gau Remi-Gau requested a review from CerenB November 12, 2020 07:45
Copy link
Collaborator

@CerenB CerenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I'll run it today!

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #178 (8582318) into dev (caab30c) will increase coverage by 0.47%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #178      +/-   ##
==========================================
+ Coverage   44.66%   45.14%   +0.47%     
==========================================
  Files          94       96       +2     
  Lines        1679     1710      +31     
==========================================
+ Hits          750      772      +22     
- Misses        929      938       +9     
Impacted Files Coverage Δ
src/reports/copyGraphWindownOutput.m 82.35% <83.33%> (-2.27%) ⬇️
src/utils/validationInputFile.m 100.00% <100.00%> (ø)
src/getAnatFilename.m 69.23% <0.00%> (-30.77%) ⬇️
src/getData.m 100.00% <0.00%> (ø)
src/QA/anatomicalQA.m 0.00% <0.00%> (ø)
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/defaults/checkOptions.m 100.00% <0.00%> (ø)
src/batches/setBatchGZip.m 0.00% <0.00%> (ø)
src/workflows/bidsGZipRawFolder.m 0.00% <0.00%> (ø)
src/setDerivativesDir.m 83.33% <0.00%> (+0.98%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caab30c...8582318. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 347ce4f into cpp-lln-lab:dev Nov 29, 2020
@Remi-Gau Remi-Gau deleted the remi-copy_figures branch November 29, 2020 17:33
@CerenB
Copy link
Collaborator

CerenB commented Jan 6, 2021

@Remi-Gau it is running and falling gracefully for sure.

On a side note, if I run more than one participant at the same time, then the figures for each participant is less than the run number. E.g. First subject has 9 figures, second subject has 8, third one has 6 .png files, and for the last subject it was 3 .png files (total is 9 == total run number).

another not so important issue is with parallel processing, the pipeline does not produce figures. And indeed it's nice that it does not crash, just reports back saying it could not copy any figures because there was none.

Warning: No figure file to copy
> In copyGraphWindownOutput (line 50)
  In copyFigures (line 39)
  In parallel_function>make_general_channel/channel_general (line 932)
  In remoteParallelFunction (line 41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants