bidsConcatBetaTmaps hoxfit for ffxDir definition in subfun

[CerenB]

Here it comes a hot-fix!
I added ffxDir folder in the subfolder to be called. otherwise remove-useless-betas-subfun is crashing.
Should fix the issue #293

[marcobarilari]

Suggested change

	removeBetaImgTmaps(beta_maps, t_maps, deleteIndBeta, deleteIndTmaps,ffxDir);
	removeBetaImgTmaps(beta_maps, t_maps, deleteIndBeta, deleteIndTmaps, ffxDir, funcFWHM);

[marcobarilari]

LGTM :) thanks

[codecov]

Codecov Report

Merging #294 (21b8f71) into dev (cbe3fee) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #294      +/-   ##
==========================================
+ Coverage   55.15%   55.20%   +0.05%     
==========================================
  Files         110      110              
  Lines        1922     1920       -2     
==========================================
  Hits         1060     1060              
+ Misses        862      860       -2     

Impacted Files	Coverage Δ
src/workflows/bidsConcatBetaTmaps.m	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe3fee...21b8f71. Read the comment docs.

[CerenB]

no no it will not work... there's another dependency, funcFWHM

[marcobarilari]

Suggested change

	function removeBetaImgTmaps(beta_maps, t_maps, deleteIndBeta, deleteIndTmaps, ffxDir)
	function removeBetaImgTmaps(beta_maps, t_maps, deleteIndBeta, deleteIndTmaps, ffxDir, funcFWHM)

[marcobarilari]

right! there you go :)

[CerenB]

uupps sorry I did it already. I will not add your changes, also I've run mh_style fix as well! thanks anyways :)

[CerenB]

Actually, the goal of subfunc is not clear to me. Do we want to delete the betas? At the current form, we do not delete all the betas because beta_maps may not give the entire beta_*.nii created. We are only deleting the betas which were used to create 4D map.
So what do we want for thus deleting to do? All the betas to be clean? If yes, why not the following:

% delete maps
  if deleteIndBeta

    % delete all individual beta maps
    fprintf('Deleting individual beta-maps ...  ');
    delete(fullfile(ffxDir, ['beta_*','.nii']))
    fprintf('Done. \n\n\n ');

  end

Is there a reason why we need to be selectively deleting some betas but others? e.g. is the user use this ffxDir for some other beta storing? if not we can delete all the betas!

[marcobarilari]

Yes, what you are saying makes sense. Though have not tested yet that part so I was not aware of that 'incomplete' behavior.

I genuinely don't know what would be the best-case scenario here.

[CerenB]

@Remi-Gau any preference? if not, I'll merge it with the deletion implemented (pls see above).

[Remi-Gau]

I have no strong preference personally, mostly because I don't think I will ever want to delete the beta maps.
So I will let you decide what the best usecase is. :-) <---- look at me delegating the decision making process!!!! Yay!!!