Skip to content

Conversation

@CerenB
Copy link
Collaborator

@CerenB CerenB commented Feb 17, 2021

when i use the concat script loop through different subjects due to the deletion option is on, matlabbatch gives an error. for every subject the clean matlabbatch should be opened. that's what this fix does.

@CerenB CerenB requested a review from marcobarilari February 17, 2021 13:09
Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah that can lead to crashes otherwise

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #296 (82f9390) into dev (e49f33f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #296      +/-   ##
==========================================
- Coverage   62.42%   62.38%   -0.04%     
==========================================
  Files         108      108              
  Lines        1698     1699       +1     
==========================================
  Hits         1060     1060              
- Misses        638      639       +1     
Impacted Files Coverage Δ
src/workflows/bidsConcatBetaTmaps.m 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49f33f...82f9390. Read the comment docs.

@CerenB CerenB merged commit e5637d1 into cpp-lln-lab:dev Feb 17, 2021
@CerenB CerenB deleted the cer-bidsConcatBeta-fix branch June 8, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants